Messages in this thread | | | From | Alex Deucher <> | Date | Mon, 27 Mar 2023 19:48:06 -0400 | Subject | Re: [PATCH 02/12] drm/amd: Remove unused variable 'value0' |
| |
On Mon, Mar 27, 2023 at 7:34 PM Caio Novais <caionovais@usp.br> wrote: > > Compiling AMD GPU drivers displays a warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_link_encoder.c: In function ‘dcn10_link_encoder_update_mst_stream_allocation_table’: > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_link_encoder.c:1222:18: warning: variable ‘value0’ set but not used [-Wunused-but-set-variable] > > Get rid of it by removing the variable. > > Signed-off-by: Caio Novais <caionovais@usp.br> > --- > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c > index c4287147b853..81aa1631945a 100644 > --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c > +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c > @@ -1219,7 +1219,6 @@ void dcn10_link_encoder_update_mst_stream_allocation_table( > const struct link_mst_stream_allocation_table *table) > { > struct dcn10_link_encoder *enc10 = TO_DCN10_LINK_ENC(enc); > - uint32_t value0 = 0; > uint32_t value1 = 0; > uint32_t value2 = 0; > uint32_t slots = 0; > @@ -1321,8 +1320,6 @@ void dcn10_link_encoder_update_mst_stream_allocation_table( > do { > udelay(10); > > - value0 = REG_READ(DP_MSE_SAT_UPDATE);
This reads a register. Removing it may adversely affect the programming sequence. If you want to avoid the set but unused warning, just drop the assignment, but leave the REG_READ.
Alex
> - > REG_GET(DP_MSE_SAT_UPDATE, > DP_MSE_SAT_UPDATE, &value1); > > -- > 2.40.0 >
| |