Messages in this thread | | | Date | Mon, 27 Mar 2023 21:05:54 +0200 | Subject | Re: [PATCH v1 1/2] dt-bindings: gpio: ds4520: Add ADI DS4520 | From | Krzysztof Kozlowski <> |
| |
On 27/03/2023 15:00, Okan Sahin wrote: > Add ADI DS4520 devicetree document. > > Signed-off-by: Okan Sahin <okan.sahin@analog.com> > --- > .../bindings/gpio/adi,ds4520-gpio.yaml | 45 +++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/adi,ds4520-gpio.yaml > > diff --git a/Documentation/devicetree/bindings/gpio/adi,ds4520-gpio.yaml b/Documentation/devicetree/bindings/gpio/adi,ds4520-gpio.yaml > new file mode 100644 > index 000000000000..69f90e59d415 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/adi,ds4520-gpio.yaml
Filename matching compatible.
> @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gpio/adi,ds4520-gpio.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: DS4520 I2C GPIO expander > + > +maintainers: > + - Okan Sahin <okan.sahin@analog.com> > + > +properties: > + compatible: > + enum: > + - adi,ds4520 > + > + reg: > + maxItems: 1 > + > + gpio-controller: true > + > + '#gpio-cells':
Use consistent quotes - either ' or ".
> + const: 2 > + > +required: > + - compatible > + - reg > + - gpio-controller > + - "#gpio-cells" > + > +additionalProperties: false > + > +examples: > + - | > + i2c0 {
i2c
> + #address-cells = <1>; > + #size-cells = <0>; > + > + ds4520: gpio@50 {
Drop the label, not used here.
> + compatible = "adi,ds4520-gpio";
As Rob's bot pointed...
Best regards, Krzysztof
| |