lkml.org 
[lkml]   [2023]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v1 4/4] clk: qcom: lpasscc-sc7280: Remove qdsp6ss clock registration
Date
The qdsp6ss memory region is being shared by ADSP remoteproc device and
lpasscc clock device, hence causing memory conflict.
As the qdsp6ss clocks are being enabled in remoteproc driver, remove the
qdsp6ss clock registration.

Fixes: 4ab43d171181 ("clk: qcom: Add lpass clock controller driver for SC7280")
Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
---
drivers/clk/qcom/lpasscc-sc7280.c | 63 +------------------------------
1 file changed, 1 insertion(+), 62 deletions(-)

diff --git a/drivers/clk/qcom/lpasscc-sc7280.c b/drivers/clk/qcom/lpasscc-sc7280.c
index 48432010ce24..4719e3fa8b05 100644
--- a/drivers/clk/qcom/lpasscc-sc7280.c
+++ b/drivers/clk/qcom/lpasscc-sc7280.c
@@ -30,48 +30,6 @@ static struct clk_branch lpass_top_cc_lpi_q6_axim_hs_clk = {
},
};

-static struct clk_branch lpass_qdsp6ss_core_clk = {
- .halt_reg = 0x20,
- /* CLK_OFF would not toggle until LPASS is out of reset */
- .halt_check = BRANCH_HALT_SKIP,
- .clkr = {
- .enable_reg = 0x20,
- .enable_mask = BIT(0),
- .hw.init = &(struct clk_init_data){
- .name = "lpass_qdsp6ss_core_clk",
- .ops = &clk_branch2_ops,
- },
- },
-};
-
-static struct clk_branch lpass_qdsp6ss_xo_clk = {
- .halt_reg = 0x38,
- /* CLK_OFF would not toggle until LPASS is out of reset */
- .halt_check = BRANCH_HALT_SKIP,
- .clkr = {
- .enable_reg = 0x38,
- .enable_mask = BIT(0),
- .hw.init = &(struct clk_init_data){
- .name = "lpass_qdsp6ss_xo_clk",
- .ops = &clk_branch2_ops,
- },
- },
-};
-
-static struct clk_branch lpass_qdsp6ss_sleep_clk = {
- .halt_reg = 0x3c,
- /* CLK_OFF would not toggle until LPASS is out of reset */
- .halt_check = BRANCH_HALT_SKIP,
- .clkr = {
- .enable_reg = 0x3c,
- .enable_mask = BIT(0),
- .hw.init = &(struct clk_init_data){
- .name = "lpass_qdsp6ss_sleep_clk",
- .ops = &clk_branch2_ops,
- },
- },
-};
-
static struct regmap_config lpass_regmap_config = {
.reg_bits = 32,
.reg_stride = 4,
@@ -90,18 +48,6 @@ static const struct qcom_cc_desc lpass_cc_top_sc7280_desc = {
.num_clks = ARRAY_SIZE(lpass_cc_top_sc7280_clocks),
};

-static struct clk_regmap *lpass_qdsp6ss_sc7280_clocks[] = {
- [LPASS_QDSP6SS_XO_CLK] = &lpass_qdsp6ss_xo_clk.clkr,
- [LPASS_QDSP6SS_SLEEP_CLK] = &lpass_qdsp6ss_sleep_clk.clkr,
- [LPASS_QDSP6SS_CORE_CLK] = &lpass_qdsp6ss_core_clk.clkr,
-};
-
-static const struct qcom_cc_desc lpass_qdsp6ss_sc7280_desc = {
- .config = &lpass_regmap_config,
- .clks = lpass_qdsp6ss_sc7280_clocks,
- .num_clks = ARRAY_SIZE(lpass_qdsp6ss_sc7280_clocks),
-};
-
static int lpass_cc_sc7280_probe(struct platform_device *pdev)
{
const struct qcom_cc_desc *desc;
@@ -121,17 +67,10 @@ static int lpass_cc_sc7280_probe(struct platform_device *pdev)
goto destroy_pm_clk;
}

- lpass_regmap_config.name = "qdsp6ss";
- desc = &lpass_qdsp6ss_sc7280_desc;
-
- ret = qcom_cc_probe_by_index(pdev, 0, desc);
- if (ret)
- goto destroy_pm_clk;
-
lpass_regmap_config.name = "top_cc";
desc = &lpass_cc_top_sc7280_desc;

- ret = qcom_cc_probe_by_index(pdev, 1, desc);
+ ret = qcom_cc_probe_by_index(pdev, 0, desc);
if (ret)
goto destroy_pm_clk;

--
2.25.1
\
 
 \ /
  Last update: 2023-03-27 18:34    [W:0.091 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site