lkml.org 
[lkml]   [2023]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/2] dt-bindings: clock: update rk3588 clock definitions
    From
    On 26/03/2023 14:02, Shane Francis wrote:
    >> Please wrap commit message according to > > Linux coding style /
    > submission
    >
    > Will do, I haven't submitted patches for a while totally forgot the
    > wrapping guidelines
    >
    >> Unfortunately the reason is not good enough > for ABI break. Replace
    >> vendor boot uboots with open-source one or > just correct them (it's still
    >> U-Boot so even for vendor one you have the source).
    >
    > Replacing uboot is fine for this case, however I can foresee that can cause
    > issues further down the line.
    >
    >
    > 1. No uboot source from the vendor, we all know no everyone respects code
    > licencing
    >
    > 2. Secure environments (like android tables), this chipset will likely end
    > up in android tablets that have the secure boot chain enable. These will be
    > unable to replace uboot even if source is available.

    So mention this in the commit msg.

    >
    > As this SoC is new to the Linux kernel (not even useable for much it's
    > current state) would it not be better to aling on this so vendor and
    > mainline DTS "agree" now rather than possibly have to address is in the
    > future ?

    Then commit msg should also mention it.



    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2023-03-27 01:18    [W:7.830 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site