Messages in this thread | | | Date | Sat, 25 Mar 2023 10:53:55 -0500 | From | Joseph Strauss <> | Subject | Re: [PATCH v2] Add multicolor support to BlinkM LED driver |
| |
On 23/03/23 12:33PM, Pavel Machek wrote: > Hi! > > > In the blinkm_probe function, the multicolor LED class is registered > > after the regular LED classes. The blinkm_set_mc_brightness() function > > had to be added to calculate the three color components and then set the > > fields of the blinkm_data structure accordingly. > > It needs to be either single multicolor LED or three separate > LEDs. But not both at the same time. >
Thank you for the feedback! How would you suggest I go about handling this? Is there a preferred way to ask the user which way they want to control the LED (Kconfig?), or should I remove the code for three separate LEDs entirely? Originally, I didn't delete the code because I thought it would be bad to remove the existing interface.
Joe Strauss
| |