Messages in this thread | | | Date | Sat, 25 Mar 2023 06:03:47 +0800 | From | kernel test robot <> | Subject | Re: [PATCH v2 4/5] cxl: CXL Performance Monitoring Unit driver |
| |
Hi Jonathan,
I love your patch! Perhaps something to improve:
[auto build test WARNING on acme/perf/core] [also build test WARNING on tip/perf/core cxl/next cxl/pending linus/master v6.3-rc3 next-20230324] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Jonathan-Cameron/cxl-Add-function-to-count-regblocks-of-a-given-type/20230325-011827 base: https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/core patch link: https://lore.kernel.org/r/20230324171313.18448-5-Jonathan.Cameron%40huawei.com patch subject: [PATCH v2 4/5] cxl: CXL Performance Monitoring Unit driver config: i386-randconfig-a001 (https://download.01.org/0day-ci/archive/20230325/202303250510.RNVcynwI-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/a04f0052a1fa10bda54569c8c7b3ab7fe60ca975 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Jonathan-Cameron/cxl-Add-function-to-count-regblocks-of-a-given-type/20230325-011827 git checkout a04f0052a1fa10bda54569c8c7b3ab7fe60ca975 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 olddefconfig make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/cxl/
If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@intel.com> | Link: https://lore.kernel.org/oe-kbuild-all/202303250510.RNVcynwI-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/cxl/cpmu.c: In function 'cpmu_parse_caps': drivers/cxl/cpmu.c:101:15: error: implicit declaration of function 'readq'; did you mean 'readl'? [-Werror=implicit-function-declaration] 101 | val = readq(base + CPMU_CAP_REG); | ^~~~~ | readl drivers/cxl/cpmu.c: In function 'cpmu_pmu_enable': drivers/cxl/cpmu.c:559:17: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration] 559 | writeq(0, base + CPMU_FREEZE_REG); | ^~~~~~ | writel In file included from include/linux/bitops.h:6, from drivers/cxl/cpmu.c:24: drivers/cxl/cpmu.c: In function 'cpmu_pmu_disable': >> include/linux/bits.h:35:18: warning: right shift count is negative [-Wshift-count-negative] 35 | (~UL(0) >> (BITS_PER_LONG - 1 - (h)))) | ^~ include/linux/bits.h:37:38: note: in expansion of macro '__GENMASK' 37 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l)) | ^~~~~~~~~ drivers/cxl/cpmu.c:578:24: note: in expansion of macro 'GENMASK' 578 | writeq(GENMASK(63, 0), base + CPMU_FREEZE_REG); | ^~~~~~~ cc1: some warnings being treated as errors
vim +35 include/linux/bits.h
295bcca84916cb Rikard Falkeborn 2020-04-06 32 295bcca84916cb Rikard Falkeborn 2020-04-06 33 #define __GENMASK(h, l) \ 95b980d62d52c4 Masahiro Yamada 2019-07-16 34 (((~UL(0)) - (UL(1) << (l)) + 1) & \ 95b980d62d52c4 Masahiro Yamada 2019-07-16 @35 (~UL(0) >> (BITS_PER_LONG - 1 - (h)))) 295bcca84916cb Rikard Falkeborn 2020-04-06 36 #define GENMASK(h, l) \ 295bcca84916cb Rikard Falkeborn 2020-04-06 37 (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l)) 8bd9cb51daac89 Will Deacon 2018-06-19 38
-- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
| |