Messages in this thread | | | Date | Fri, 24 Mar 2023 16:41:59 -0500 | From | Bjorn Helgaas <> | Subject | Re: [PATCH v2 3/5] pci/aer: Export cper_print_aer() for CXL driver logging |
| |
On Thu, Mar 23, 2023 at 04:38:06PM -0500, Terry Bowman wrote: > The CXL driver plans to use cper_print_aer() for restricted CXL host > (RCH) logging. cper_print_aer() is not exported and as a result is not > available to the CXL driver or other loadable modules. Export > cper_print_aer() making it available to CXL and other loadable modules. > > Signed-off-by: Terry Bowman <terry.bowman@amd.com> > Cc: Mahesh J Salgaonkar <mahesh@linux.ibm.com> > Cc: "Oliver O'Halloran" <oohall@gmail.com> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: linux-pci@vger.kernel.org
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
But please update the subject line to:
PCI/AER: Export cper_print_aer() for use by modules
to match previous history.
> --- > drivers/pci/pcie/aer.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c > index 625f7b2cafe4..7f0f52d094a4 100644 > --- a/drivers/pci/pcie/aer.c > +++ b/drivers/pci/pcie/aer.c > @@ -809,6 +809,7 @@ void cper_print_aer(struct pci_dev *dev, int aer_severity, > trace_aer_event(dev_name(&dev->dev), (status & ~mask), > aer_severity, tlp_header_valid, &aer->header_log); > } > +EXPORT_SYMBOL_GPL(cper_print_aer); > #endif > > /** > -- > 2.34.1 >
| |