Messages in this thread | | | Date | Thu, 23 Mar 2023 18:02:35 +0100 | From | Andrew Lunn <> | Subject | Re: [net-next PATCH v5 15/15] arm: mvebu: dt: Add PHY LED support for 370-rd WAN port |
| |
On Thu, Mar 23, 2023 at 01:04:53PM +0100, Pavel Machek wrote: > Hi! > > > From: Andrew Lunn <andrew@lunn.ch> > > > > The WAN port of the 370-RD has a Marvell PHY, with one LED on > > the front panel. List this LED in the device tree. > > > > Signed-off-by: Andrew Lunn <andrew@lunn.ch> > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > > > @@ -135,6 +136,19 @@ &mdio { > > pinctrl-names = "default"; > > phy0: ethernet-phy@0 { > > reg = <0>; > > + leds { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + led@0 { > > + reg = <0>; > > + label = "WAN"; > > + color = <LED_COLOR_ID_WHITE>; > > + function = LED_FUNCTION_LAN; > > + function-enumerator = <1>; > > + linux,default-trigger = "netdev"; > > + }; > > + }; > > }; > > > > How will this end up looking in sysfs?
Hi Pavel
It is just a plain boring LED, so it will look like all other LEDs. There is nothing special here.
> Should documentation be added to Documentation/leds/leds-blinkm.rst > ?
This has nothing to do with blinkm, which appears to be an i2c LED driver.
Andrew
| |