Messages in this thread Patch in this message | | | Date | Wed, 22 Mar 2023 09:22:25 -0000 | From | "tip-bot2 for Tom Rix" <> | Subject | [tip: sched/core] sched/topology: Make sched_energy_mutex,update static |
| |
The following commit has been merged into the sched/core branch of tip:
Commit-ID: d91e15a21d4b3823ce93a42b05f0d171689f4e6a Gitweb: https://git.kernel.org/tip/d91e15a21d4b3823ce93a42b05f0d171689f4e6a Author: Tom Rix <trix@redhat.com> AuthorDate: Tue, 14 Mar 2023 10:48:18 -04:00 Committer: Peter Zijlstra <peterz@infradead.org> CommitterDate: Wed, 22 Mar 2023 10:10:57 +01:00
sched/topology: Make sched_energy_mutex,update static
smatch reports kernel/sched/topology.c:212:1: warning: symbol 'sched_energy_mutex' was not declared. Should it be static? kernel/sched/topology.c:213:6: warning: symbol 'sched_energy_update' was not declared. Should it be static?
These variables are only used in topology.c, so should be static
Signed-off-by: Tom Rix <trix@redhat.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: Valentin Schneider <vschneid@redhat.com> Link: https://lore.kernel.org/r/20230314144818.1453523-1-trix@redhat.com --- kernel/sched/topology.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 051aaf6..6682535 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -209,8 +209,8 @@ sd_parent_degenerate(struct sched_domain *sd, struct sched_domain *parent) #if defined(CONFIG_ENERGY_MODEL) && defined(CONFIG_CPU_FREQ_GOV_SCHEDUTIL) DEFINE_STATIC_KEY_FALSE(sched_energy_present); static unsigned int sysctl_sched_energy_aware = 1; -DEFINE_MUTEX(sched_energy_mutex); -bool sched_energy_update; +static DEFINE_MUTEX(sched_energy_mutex); +static bool sched_energy_update; void rebuild_sched_domains_energy(void) {
| |