Messages in this thread | | | From | Zheng Hacker <> | Date | Thu, 23 Mar 2023 11:49:06 +0800 | Subject | Re: [PATCH net v2] net: qcom/emac: Fix use after free bug in emac_remove due to race condition |
| |
Jakub Kicinski <kuba@kernel.org> 于2023年3月21日周二 03:23写道: > > On Mon, 20 Mar 2023 09:20:17 +0000 patchwork-bot+netdevbpf@kernel.org > wrote: > > Here is the summary with links: > > - [net,v2] net: qcom/emac: Fix use after free bug in emac_remove due to race condition > > https://git.kernel.org/netdev/net/c/6b6bc5b8bd2d > > Don't think this is correct FWIW, randomly shutting things down without > holding any locks and before unregister_netdev() is called has got to > be racy. Oh, eh.
Dear Jakubju,
Sorry for my late reply. I had a busy week.
I have taken a look at similar fixes implemented in other drivers, but I do think your advice is more precious for I'm not familiar with the driver.
Based on your experience and expertise, what do you think would be the most effective solution to address the race condition issue that you have identified in the emac_remove function of the qcom/emac driver? I appreciate any insights or suggestions that you might have on this matter.
Thank you for your time and help.
Best regards, Zheng Wang
| |