Messages in this thread | ![/](/images/icornerl.gif) | | From | Ping-Ke Shih <> | Subject | RE: [PATCH v3 3/9] wifi: rtw88: mac: Support SDIO specific bits in the power on sequence | Date | Thu, 23 Mar 2023 02:27:24 +0000 |
| |
> -----Original Message----- > From: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Sent: Tuesday, March 21, 2023 5:35 AM > To: linux-wireless@vger.kernel.org > Cc: Yan-Hsuan Chuang <tony0620emma@gmail.com>; Kalle Valo <kvalo@kernel.org>; Ulf Hansson > <ulf.hansson@linaro.org>; linux-kernel@vger.kernel.org; netdev@vger.kernel.org; > linux-mmc@vger.kernel.org; Chris Morgan <macroalpha82@gmail.com>; Nitin Gupta <nitin.gupta981@gmail.com>; > Neo Jou <neojou@gmail.com>; Ping-Ke Shih <pkshih@realtek.com>; Jernej Skrabec <jernej.skrabec@gmail.com>; > Larry Finger <Larry.Finger@lwfinger.net>; Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Subject: [PATCH v3 3/9] wifi: rtw88: mac: Support SDIO specific bits in the power on sequence > > Add the code specific to SDIO HCI in the MAC power on sequence. This is > based on the RTL8822BS and RTL8822CS vendor drivers. > > Co-developed-by: Jernej Skrabec <jernej.skrabec@gmail.com> > Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com> > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
> --- > - add sdio.h include in patch 2 already (instead of patch 3) as > suggested by Larry Finger (thank you!) so the build doesn't break > during bisect > - only set RTW_FLAG_POWERON when applying the power on sequence was > successful (thanks for the suggestion Ping-Ke!) > - fix smatch false positive "uninitialized symbol 'imr'" in > rtw_mac_power_switch() by initializing imr to 0. Thanks for spotting > this and for the suggestion Ping-Ke! > > Changes since v1: > - only access REG_SDIO_HIMR for RTW_HCI_TYPE_SDIO > - use proper BIT_HCI_SUS_REQ, BIT_HCI_RESUME_RDY and BIT_SDIO_PAD_E5 > macros as suggested by Ping-Ke > >
[...]
| ![\](/images/icornerr.gif) |