lkml.org 
[lkml]   [2023]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/1] x86/irq: Add hardcoded hypervisor interrupts to /proc/stat
From
On 2/27/23 10:46, Michael Kelley wrote:
> diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
> index 766ffe3..9f668d2 100644
> --- a/arch/x86/kernel/irq.c
> +++ b/arch/x86/kernel/irq.c
> @@ -211,6 +211,13 @@ u64 arch_irq_stat_cpu(unsigned int cpu)
> #ifdef CONFIG_X86_MCE_THRESHOLD
> sum += irq_stats(cpu)->irq_threshold_count;
> #endif
> +#ifdef CONFIG_X86_HV_CALLBACK_VECTOR
> + sum += irq_stats(cpu)->irq_hv_callback_count;
> +#endif
> +#if IS_ENABLED(CONFIG_HYPERV)
> + sum += irq_stats(cpu)->irq_hv_reenlightenment_count;
> + sum += irq_stats(cpu)->hyperv_stimer0_count;
> +#endif
> #ifdef CONFIG_X86_MCE
> sum += per_cpu(mce_exception_count, cpu);
> sum += per_cpu(mce_poll_count, cpu);

This seems fine, especially since arch_show_interrupts() has them. But,
what's with the "#if IS_ENABLED" versus the plain #ifdef? Is there some
difference I'm missing? Why not just be consistent with the other code
and use a plain #ifdef for both?

\
 
 \ /
  Last update: 2023-03-27 01:12    [W:0.175 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site