lkml.org 
[lkml]   [2023]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/3] kvm: vmx: Add IA32_FLUSH_CMD guest support
From
On Mon, Mar 20, 2023, Sean Christopherson wrote:
> On Fri, Mar 17, 2023, Pawan Gupta wrote:
> > Thats what I think, and if its too late to be squashed I will send a
> > formal patch. Maintainers?
>
> Honestly, I'd rather revert the whole mess and try again. The patches obviously
> weren't tested, and the entire approach (that was borrowed from the existing
> MSR_IA32_PRED_CMD code) makes no sense.

Yeah, revert incoming. This is just the tip of the iceberg. SVM completely drops
the error, which is why there are no boot failures on AMD despite having the same
broken logic. Neither SVM nor VMX marks the MSR as being passthrough friendly and
thus breaks MSR filtering.

\
 
 \ /
  Last update: 2023-03-27 01:11    [W:0.190 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site