Messages in this thread | | | Date | Wed, 22 Mar 2023 00:17:28 +0200 | Subject | Re: [PATCH v2 01/10] dt-bindings: serial: snps-dw-apb-uart: Switch dma-names order | From | Cristian Ciocaltea <> |
| |
On 3/22/23 00:09, Conor Dooley wrote: > On Tue, Mar 21, 2023 at 11:56:15PM +0200, Cristian Ciocaltea wrote: >> Commit 370f696e4474 ("dt-bindings: serial: snps-dw-apb-uart: add dma & >> dma-names properties") documented dma-names property to handle Allwinner >> D1 dtbs_check warnings, but relies on the rx->tx ordering, which is the >> reverse of what a different board expects: >> >> rk3326-odroid-go2.dtb: serial@ff030000: dma-names:0: 'rx' was expected >> >> A quick and incomplete check shows the inconsistency is present in many >> other DTS files: > >> The initial proposed solution was to allow a flexible dma-names order in >> the binding, due to potential ABI breakage concerns after fixing the DTS >> files. But luckily the Allwinner boards are not really affected, since >> all of them are using a shared DMA channel for rx and tx: > >> Switch dma-names order to tx->rx as the first step in fixing the >> inconsistency. The remaining DTS fixes will be handled by separate >> patches. >> >> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > Thanks for doing all of the switch overs too. I should've probably > broadened my searching beyond the allwinner platforms when I initially > added this, so yeah, thanks.
Thanks for the quick review! And no worries, I'm glad I could help, hopefully I didn't miss anything..
| |