Messages in this thread | | | Date | Mon, 20 Mar 2023 15:18:58 +0100 | Subject | Re: [PATCH 2/2] platform/x86/intel/pmt/telemetry: Add driver version | From | Hans de Goede <> |
| |
Hi,
On 3/17/23 14:35, Andy Shevchenko wrote: > On Fri, Mar 17, 2023 at 12:57 AM David E. Box > <david.e.box@linux.intel.com> wrote: >> >> Add a driver version number to make it easier to track changes in >> backported kernels. > > Sorry, but NAK. As Greg KH said, we do not use this anymore (in Git > era) — the SHA from the Git _is_ the version of the driver.
I agree with Andy per driver version numbers are really not useful.
Generally speaking the version number will get updated say once per upstream kernel-release in a separate commit, but there is no guarantee that commit will get cherry-picked together with other cherry-picked fixes.
So for downstream kernels these version numbers really don't have any meaning and as such are useless.
Regards,
Hans
| |