Messages in this thread | | | Subject | Re: [PATCH] net: cxgb3: remove unused fl_to_qset function | From | Tom Rix <> | Date | Mon, 20 Mar 2023 05:29:51 -0700 |
| |
On 3/19/23 10:45 AM, Horatiu Vultur wrote: > The 03/19/2023 13:24, Tom Rix wrote: > > Hi Tom, > >> clang with W=1 reports >> drivers/net/ethernet/chelsio/cxgb3/sge.c:169:32: error: unused function >> 'fl_to_qset' [-Werror,-Wunused-function] >> static inline struct sge_qset *fl_to_qset(const struct sge_fl *q, int qidx) >> ^ >> This function is not used, so remove it. > Don't forget to mention in the subject which tree is targeting this > patch.
This and all my similar fixes/cleanup are against -next.
What prefix would you like to see ?
Tom
> Other than that looks OK. > > Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com> > >> Signed-off-by: Tom Rix <trix@redhat.com> >> --- >> drivers/net/ethernet/chelsio/cxgb3/sge.c | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/drivers/net/ethernet/chelsio/cxgb3/sge.c b/drivers/net/ethernet/chelsio/cxgb3/sge.c >> index 62dfbdd33365..efa7f401529e 100644 >> --- a/drivers/net/ethernet/chelsio/cxgb3/sge.c >> +++ b/drivers/net/ethernet/chelsio/cxgb3/sge.c >> @@ -166,11 +166,6 @@ static u8 flit_desc_map[] = { >> #endif >> }; >> >> -static inline struct sge_qset *fl_to_qset(const struct sge_fl *q, int qidx) >> -{ >> - return container_of(q, struct sge_qset, fl[qidx]); >> -} >> - >> static inline struct sge_qset *rspq_to_qset(const struct sge_rspq *q) >> { >> return container_of(q, struct sge_qset, rspq); >> -- >> 2.27.0 >>
| |