Messages in this thread | | | Subject | Re: [PATCH v3 0/3] blk-integrity: drop integrity_kobj from gendisk | From | "Martin K. Petersen" <> | Date | Mon, 20 Mar 2023 07:56:58 -0400 |
| |
Thomas,
> The embedded member integrity_kobj member of struct gendisk violates > the assumption of the driver core that only one struct kobject should > be embedded into another object and then manages its lifetime. > > As the integrity_kobj is only used to hold a few sysfs attributes it > can be replaced by direct device_attributes and removed.
Looks good to me and passed a quick test on a couple of systems. Thanks for cleaning this up!
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
-- Martin K. Petersen Oracle Linux Engineering
| |