Messages in this thread | | | Date | Mon, 20 Mar 2023 13:11:04 +0200 | From | Mike Rapoport <> | Subject | Re: [PATCH 02/15] mm/cma: move init_cma_reserved_pages() to cma.c and make it static |
| |
On Mon, Mar 20, 2023 at 11:30:20AM +0100, David Hildenbrand wrote: > On 19.03.23 22:59, Mike Rapoport wrote: > > From: "Mike Rapoport (IBM)" <rppt@kernel.org> > > > > init_cma_reserved_pages() only used in cma.c, no point of having it in > > page_alloc.c. > > > > Move init_cma_reserved_pages() to cma.c and make it static. > > I guess the motivation is to avoid letting too many subsystems mess with > pageblock migratetypes, managed pages, PG_reserved ...
Judging by the git log it just ended up in page_alloc.c because set_pageblock_migratetype() was static back then ;)
> So it kind of makes sense to have these low-level details out of common CMA > code, no?
I don't mind keeping it out of cma and folding this into "grand move" patch.
> -- > Thanks, > > David / dhildenb >
-- Sincerely yours, Mike.
| |