Messages in this thread | | | From | Nick Alcock <> | Subject | Re: [PATCH 09/20] clk: renesas: remove MODULE_LICENSE in non-modules | Date | Mon, 20 Mar 2023 11:08:35 +0000 |
| |
On 28 Feb 2023, Geert Uytterhoeven outgrape:
> Hi Nick, > > On Tue, Feb 28, 2023 at 2:03 PM Nick Alcock <nick.alcock@oracle.com> wrote: >> Since commit 8b41fc4454e ("kbuild: create modules.builtin without >> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations >> are used to identify modules. As a consequence, uses of the macro >> in non-modules will cause modprobe to misidentify their containing >> object file as a module when it is not (false positives), and modprobe >> might succeed rather than failing with a suitable error message. >> >> So remove it in the files in this commit, none of which can be built as >> modules. >> >> Signed-off-by: Nick Alcock <nick.alcock@oracle.com> >> Suggested-by: Luis Chamberlain <mcgrof@kernel.org> > > Thanks for your patch! > >> drivers/clk/renesas/rcar-usb2-clock-sel.c | 1 - > > I think it would make sense to make CLK_RCAR_USB2_CLOCK_SEL > tristate. Shimoda-san?
This patch touches three files, so I hope that means the MODULE_LICENSE removal from drivers/clk/renesas/renesas-cpg-mssr.c and drivers/clk/renesas/rzg2l-cpg.c is OK :)
| |