Messages in this thread | | | Date | Mon, 20 Mar 2023 10:07:04 +0100 (CET) | From | Julia Lawall <> | Subject | Re: [PATCH v2] Staging: nvec: Convert to_nvec_led from a macro to an inline function |
| |
On Mon, 20 Mar 2023, Sumitra Sharma wrote:
> On Mon, Mar 20, 2023 at 08:39:49AM +0300, Dan Carpenter wrote: > > On Sat, Mar 18, 2023 at 10:52:50AM -0700, Sumitra Sharma wrote: > > > Convert to_nvec_led from a macro to a static inline function, to make the > > > relevant types apparent in the definition and to benefit from the type > > > checking performed by the compiler at call sites. > > > > > > Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com> > > > --- > > > > You need to compile test your changes. > > > > Hi dan, > > I am facing problems in creating modules and in compiling them.
Note that unless the code is under an ifdef for a module, you don't specifically need the driver to be configured as for a module either. Since you don't have the device, you aren't going to be able to test it anyway. So 'y' is fine.
julia
> > Any help in this would be appreciated. Here is the link to the thread https://lore.kernel.org/outreachy/alpine.DEB.2.22.394.2303191336090.2867@hadrien/T/#t > > Regards, > > Sumitra > > > regards, > > dan carpenter > > > >
| |