Messages in this thread | | | Date | Tue, 21 Mar 2023 11:26:46 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH] crypto: caam: Clear some memory in instantiate_rng() |
| |
On Tue, Mar 21, 2023 at 12:45:43AM +0100, Christophe JAILLET wrote: > According to the comment at the end of the 'for' loop just a few lines > below, it looks needed to clear 'desc'. > > So it should also be cleared for the first iteration. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > This patch is speculative, but can't hurt. > > Maybe the memset() at the end of the 'for' loop could be removed instead.
I think the memset can be removed. Horia? -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |