Messages in this thread | | | Date | Mon, 20 Mar 2023 23:19:23 +0200 | Subject | Re: [PATCH v2] staging: most: use inline functions for iface_to_hdm | From | Menna Mahmoud <> |
| |
On ٢٠/٣/٢٠٢٣ ٢٣:١٧, Julia Lawall wrote: > Maybe "define iface_to_hdm as an inline function" would be better. "use" > is not very precise.
Okay, I will edit it.
Menna
> > julia > > On Mon, 20 Mar 2023, Menna Mahmoud wrote: > >> Convert `iface_to_hdm` macro into a static inline function. >> it is not great to have macro that use `container_of` macro, >> because from looking at the definition one cannot tell >> what type it applies to. >> >> One can get the same benefit from an efficiency point of view >> by making an inline function. >> >> Suggested-by: Julia Lawall <julia.lawall@inria.fr> >> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com> >> --- >> change in v2: >> edit subject line. >> --- >> drivers/staging/most/dim2/dim2.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c >> index b8bd01ca1f11..21d1c9f24c3d 100644 >> --- a/drivers/staging/most/dim2/dim2.c >> +++ b/drivers/staging/most/dim2/dim2.c >> @@ -108,7 +108,10 @@ struct dim2_platform_data { >> u8 fcnt; >> }; >> >> -#define iface_to_hdm(iface) container_of(iface, struct dim2_hdm, most_iface) >> +static inline struct dim2_hdm *iface_to_hdm(struct most_interface *iface) >> +{ >> + return container_of(iface, struct dim2_hdm, most_iface); >> +} >> >> /* Macro to identify a network status message */ >> #define PACKET_IS_NET_INFO(p) \ >> -- >> 2.34.1 >> >>
| |