Messages in this thread | | | Subject | Re: [PATCH 7/7 v4] sh: mcount.S: fix build error when PRINTK is not enabled | From | John Paul Adrian Glaubitz <> | Date | Mon, 20 Mar 2023 21:09:31 +0100 |
| |
On Sun, 2023-03-05 at 20:00 -0800, Randy Dunlap wrote: > Fix a build error in mcount.S when CONFIG_PRINTK is not enabled. > Fixes this build error: > > sh2-linux-ld: arch/sh/lib/mcount.o: in function `stack_panic': > (.text+0xec): undefined reference to `dump_stack' > > Fixes: e460ab27b6c3 ("sh: Fix up stack overflow check with ftrace disabled.") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> > Cc: Yoshinori Sato <ysato@users.sourceforge.jp> > Cc: Rich Felker <dalias@libc.org> > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > Cc: stable@vger.kernel.org > --- > v2: add PRINTK to STACK_DEBUG dependency (thanks, Geert) > v3: skipped > v4: refresh & resend > > arch/sh/Kconfig.debug | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -- a/arch/sh/Kconfig.debug b/arch/sh/Kconfig.debug > --- a/arch/sh/Kconfig.debug > +++ b/arch/sh/Kconfig.debug > @@ -15,7 +15,7 @@ config SH_STANDARD_BIOS > > config STACK_DEBUG > bool "Check for stack overflows" > - depends on DEBUG_KERNEL > + depends on DEBUG_KERNEL && PRINTK > help > This option will cause messages to be printed if free stack space > drops below a certain limit. Saying Y here will add overhead to
Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
-- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
| |