Messages in this thread | | | Date | Mon, 20 Mar 2023 20:31:36 +0100 | From | Andrew Lunn <> | Subject | Re: [net-next PATCH v5 04/15] leds: Provide stubs for when CLASS_LED is disabled |
| |
On Mon, Mar 20, 2023 at 06:52:47PM +0100, Christian Marangi wrote: > On Sun, Mar 19, 2023 at 11:49:02PM +0100, Andrew Lunn wrote: > > > +#if IS_ENABLED(CONFIG_LEDS_CLASS) > > > enum led_default_state led_init_default_state_get(struct fwnode_handle *fwnode); > > > +#else > > > +static inline enum led_default_state > > > +led_init_default_state_get(struct fwnode_handle *fwnode) > > > +{ > > > + return LEDS_DEFSTATE_OFF; > > > +} > > > +#endif > > > > 0-day is telling me i have this wrong. The function is in led-core.c, > > so this should be CONFIG_NEW_LEDS, not CONFIG_LEDS_CLASS. > > > > Any idea why? NEW_LEDS just enable LEDS_CLASS selection so why we need > to use that? Should not make a difference (in theory)
0-day came up with a configuration which resulted in NEW_LEDS enabled but LEDS_CLASS disabled. That then resulted in multiple definitions of led_init_default_state_get() when linking.
I _guess_ this is because select is used, which is not mandatory. So randconfig can turn off something which is enabled by select.
I updated my tree, and so far 0-day has not complained, but it can take a few days when it is busy.
Andrew
| |