Messages in this thread | | | Date | Mon, 20 Mar 2023 11:51:11 -0700 | Subject | Re: [PATCH 06/21] KVM: x86/mmu: Get rid of is_cpuid_PSE36() | From | Sean Christopherson <> |
| |
On Thu, Feb 02, 2023, Ben Gardon wrote: > is_cpuid_PSE36() always returns 1 and is never overridden, so just get > rid of the function. This saves having to export it in a future commit > in order to move the include of paging_tmpl.h out of mmu.c.
Probably won't matter as I suspect this series is going to end up a burner way in the back, but FWIW I'd prefer to preserve is_cpuid_PSE36() in some capacity. I 100% agree the helper is silly, but the mere existice of the flag is so esoteric these days that I like having obvious/obnoxious code to call it out.
| |