Messages in this thread | | | Date | Mon, 20 Mar 2023 20:27:36 +0200 | Subject | Re: [PATCH v3] staging: greybus: use inline function for macros | From | Menna Mahmoud <> |
| |
On ٢٠/٣/٢٠٢٣ ١٧:٤٢, Greg KH wrote: > On Mon, Mar 20, 2023 at 12:32:58PM +0200, Menna Mahmoud wrote: >> Convert `to_gbphy_dev` and `to_gbphy_driver` macros into a >> static inline function. >> >> it is not great to have macro that use `container_of` macro, >> because from looking at the definition one cannot tell what type >> it applies to. >> >> One can get the same benefit from an efficiency point of view >> by making an inline function. >> >> Suggested-by: Julia Lawall <julia.lawall@inria.fr> >> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com> >> --- >> change in v2: >> remove newlines added in previous patch. >> >> change in v3: >> fix the patch to be against Greg's tree. > I am lost in a twisty maze of patches from you for the greybus code that > all seem alike but are different :(
I am sorry for that.
> Can you send a patch series of the latest changes you have made, as I > really don't know what is, and is not, the latest versions at all, so > I'm going to have to drop them all from my review queue right now.
Sure, I will.
> > thanks, > > greg k-h
Thanks,
Menna
| |