lkml.org 
[lkml]   [2023]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ftrace: set direct_ops storage-class-specifier to static
On Mon, 20 Mar 2023 17:44:13 +0000
Mark Rutland <mark.rutland@arm.com> wrote:

> On Sat, Mar 11, 2023 at 08:51:13AM -0500, Tom Rix wrote:
> > smatch reports this warning
> > kernel/trace/ftrace.c:2594:19: warning:
> > symbol 'direct_ops' was not declared. Should it be static?
> >
> > The variable direct_ops is only used in ftrace.c, so it should be static
> >
> > Signed-off-by: Tom Rix <trix@redhat.com>
>
> This makes sense, and as this stands:
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
>
> ... but Florent's rework of the API is going to remove this anyway:
>
> https://lore.kernel.org/all/20230316173811.1223508-1-revest@chromium.org/
> https://lore.kernel.org/all/20230316173811.1223508-4-revest@chromium.org/
>
> ... so if we take Florent's series, this patch isn't necessary.

Except that it's already upstream:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8732565549011cabbea08329a1aefd78a68d96c7

I had to rebase Florent's patch to accommodate this change.

-- Steve

\
 
 \ /
  Last update: 2023-03-27 01:09    [W:0.154 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site