Messages in this thread | | | Date | Mon, 20 Mar 2023 10:38:12 -0700 | From | Kees Cook <> | Subject | Re: [PATCH][next] wifi: carl9170: Replace fake flex-array with flexible-array member |
| |
On Fri, Mar 17, 2023 at 11:39:36AM -0600, Gustavo A. R. Silva wrote: > Zero-length arrays as fake flexible arrays are deprecated and we are > moving towards adopting C99 flexible-array members instead. > > Address the following warnings found with GCC-13 and > -fstrict-flex-arrays=3 enabled: > drivers/net/wireless/ath/carl9170/tx.c:702:61: warning: array subscript i is outside array bounds of ‘const struct _carl9170_tx_status[0]’ [-Warray-bounds=] > drivers/net/wireless/ath/carl9170/tx.c:701:65: warning: array subscript i is outside array bounds of ‘const struct _carl9170_tx_status[0]’ [-Warray-bounds=] > > This helps with the ongoing efforts to tighten the FORTIFY_SOURCE > routines on memcpy() and help us make progress towards globally > enabling -fstrict-flex-arrays=3 [1]. > > Link: https://github.com/KSPP/linux/issues/21 > Link: https://github.com/KSPP/linux/issues/267 > Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [1] > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
This one threw me for a moment, but then realized the patch context couldn't see the union that wrapped them. :)
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |