Messages in this thread | | | Date | Mon, 20 Mar 2023 18:54:16 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH 4/4] counter: 104-quad-8: Utilize helper functions to handle PR, FLAG and PSC |
| |
On Mon, Mar 20, 2023 at 11:53:36AM -0400, William Breathitt Gray wrote: > On Mon, Mar 20, 2023 at 05:36:17PM +0200, Andy Shevchenko wrote:
...
> After reading through the implementation for these functions I realized > they are actually doing something different than what's happening here. > The 104-QUAD-8 device exposes the 24-bit register by consecutive 8-bit > I/O operations on the same address; however, the iomap_copy and regmap > bulk functions operate on different addresses.
Ah, than we have ioreadXX_rep()/iowriteXX_rep() for that.
> I'm not sure if there really is a way to make the 104-QUAD-8 operation > more generic for other drivers because it configures the current byte > pointer through a separate register from the data register (all of this > feel rather device specific), so I suspect keeping this function local > to 104-quad-8 is best for now.
-- With Best Regards, Andy Shevchenko
| |