Messages in this thread | | | Date | Mon, 20 Mar 2023 17:50:21 +0100 | Subject | Re: [PATCH 01/10] dt: bindings: clock: add mtmips SoCs clock device tree binding documentation | From | Krzysztof Kozlowski <> |
| |
On 20/03/2023 17:43, Arınç ÜNAL wrote: > On 20.03.2023 19:36, Krzysztof Kozlowski wrote: >> On 20/03/2023 17:18, Sergio Paracuellos wrote: >>> Adds device tree binding documentation for clocks and resets in the >>> Mediatek MIPS and Ralink SOCs. This covers RT2880, RT3050, RT3052, RT3350, >>> RT3883, RT5350, MT7620, MT7628 and MT7688 SoCs. >> >> Use subject prefixes matching the subsystem (which you can get for >> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory >> your patch is touching). >> >> Subject: drop second/last, redundant "device tree binding >> documentation". The "dt-bindings" prefix is already stating that these >> are bindings. >> (BTW, that's the longest redundant component I ever saw) >> >>> >>> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> >>> --- >>> .../bindings/clock/mtmips-clock.yaml | 68 +++++++++++++++++++ >>> 1 file changed, 68 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/clock/mtmips-clock.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/clock/mtmips-clock.yaml b/Documentation/devicetree/bindings/clock/mtmips-clock.yaml >>> new file mode 100644 >>> index 000000000000..c92969ce231d >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/clock/mtmips-clock.yaml >> >> Filename matching compatible, so vendor prefix and device name (or >> family of names). > > I influenced Sergio to use MTMIPS here as I want to designate it the > family name for the MediaTek MIPS and Ralink SoCs.
I don't know how to respond to this. Is it argument for not using naming style?
> We can't change the > compatible string as it's established from my pinctrl patch series we > don't do that.
The patch did not say it is documenting existing compatibles in the kernel DTS. And if we are at this, ralink,rt2880-reset does not look like single clock nor like clock controller.
Best regards, Krzysztof
| |