Messages in this thread | | | Date | Thu, 2 Mar 2023 11:21:33 +0200 | From | Leon Romanovsky <> | Subject | Re: [net PATCH] octeontx2-af: Fix start and end bit for scan config |
| |
On Thu, Mar 02, 2023 at 08:58:55AM +0530, Ratheesh Kannoth wrote: > for_each_set_bit_from() needs start bit as one bit prior > and end bit as one bit post position in the bit map > > Fixes: 88fffc65f940 (octeontx2-af: Exact match scan from kex profile)
This is wrong Fixes line. It should be: Fixes: 812103edf670 ("octeontx2-af: Exact match scan from kex profile")
Thanks
> Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com> > Reviewed-by: Sunil Kovvuri Goutham <sgoutham@marvell.com> > --- > drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c > index 327d3c6b1175..9c7bbef27e31 100644 > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c > @@ -603,9 +603,8 @@ static int npc_scan_kex(struct rvu *rvu, int blkaddr, u8 intf) > * exact match code. > */ > masked_cfg = cfg & NPC_EXACT_NIBBLE; > - bitnr = NPC_EXACT_NIBBLE_START; > - for_each_set_bit_from(bitnr, (unsigned long *)&masked_cfg, > - NPC_EXACT_NIBBLE_START) { > + bitnr = NPC_EXACT_NIBBLE_START - 1; > + for_each_set_bit_from(bitnr, (unsigned long *)&masked_cfg, NPC_EXACT_NIBBLE_END + 1) { > npc_scan_exact_result(mcam, bitnr, key_nibble, intf); > key_nibble++; > } > -- > 2.25.1 >
| |