lkml.org 
[lkml]   [2023]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/3] leds: simatic-ipc-leds-gpio: move two extra gpio pins into another table
Am Wed, 1 Mar 2023 19:21:53 +0200
schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:

> On Wed, Mar 01, 2023 at 06:02:13PM +0100, Henning Schild wrote:
> > There are two special pins needed to init the LEDs. We used to have
> > them at the end of the gpiod_lookup table to give to "leds-gpio". A
> > cleaner way is to have a dedicated table for the special pins.
>
> ...
>
> > + .dev_id = NULL,
>
> Technically speaking this is redundant. Maybe you wanted to be more
> explicit with a comment like
>
> .dev_id = NULL, /* Filled during
> initialization */
>
> ...
>
> > + .dev_id = NULL,
>
> Ditto.

Sorry you already pointed that out earlier, it slipped back in with
the rewrite.

Henning

\
 
 \ /
  Last update: 2023-03-27 00:41    [W:0.071 / U:0.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site