lkml.org 
[lkml]   [2023]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 6.1 16/29] scsi: mpi3mr: Driver unload crashes host when enhanced logging is enabled
    Date
    From: Ranjan Kumar <ranjan.kumar@broadcom.com>

    [ Upstream commit 5b06a7169c59ce0c77ef8b9c82aa07c478f82aac ]

    Prevent driver from trying to dereference a NULL pointer in a debug print
    while removing a device during driver unload.

    Signed-off-by: Ranjan Kumar <ranjan.kumar@broadcom.com>
    Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
    Link: https://lore.kernel.org/r/20230228140835.4075-3-ranjan.kumar@broadcom.com
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/mpi3mr/mpi3mr_transport.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/scsi/mpi3mr/mpi3mr_transport.c b/drivers/scsi/mpi3mr/mpi3mr_transport.c
    index 3b61815979dab..b795a325534d3 100644
    --- a/drivers/scsi/mpi3mr/mpi3mr_transport.c
    +++ b/drivers/scsi/mpi3mr/mpi3mr_transport.c
    @@ -1552,7 +1552,8 @@ static void mpi3mr_sas_port_remove(struct mpi3mr_ioc *mrioc, u64 sas_address,

    list_for_each_entry_safe(mr_sas_phy, next_phy,
    &mr_sas_port->phy_list, port_siblings) {
    - if ((mrioc->logging_level & MPI3_DEBUG_TRANSPORT_INFO))
    + if ((!mrioc->stop_drv_processing) &&
    + (mrioc->logging_level & MPI3_DEBUG_TRANSPORT_INFO))
    dev_info(&mr_sas_port->port->dev,
    "remove: sas_address(0x%016llx), phy(%d)\n",
    (unsigned long long)
    --
    2.39.2
    \
     
     \ /
      Last update: 2023-03-27 01:07    [W:2.154 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site