Messages in this thread | | | From | Linus Walleij <> | Date | Sun, 19 Mar 2023 22:03:52 +0100 | Subject | Re: [PATCH V9 4/6] pinctrl: qcom: Add IPQ9574 pinctrl driver |
| |
On Sun, Mar 19, 2023 at 10:02 PM Linus Walleij <linus.walleij@linaro.org> wrote: > On Thu, Mar 16, 2023 at 8:31 AM Devi Priya <quic_devipriy@quicinc.com> wrote: > > > Add pinctrl definitions for the TLMM of IPQ9574 > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Co-developed-by: Anusha Rao <quic_anusha@quicinc.com> > > Signed-off-by: Anusha Rao <quic_anusha@quicinc.com> > > Signed-off-by: Devi Priya <quic_devipriy@quicinc.com> > > --- > > Changes in V9: > > - Added COMPILE_TEST for non-OF configurations in config PINCTRL_IPQ9574 > > - Unwrapped the lines for PINGROUP 34 & 62 in ipq9574_groups > > - Removed the comma from terminator line in ipq9574_pinctrl_of_match[] array > > - Moved the MODULE_DEVICE_TABLE entry just below the array > > ipq9574_pinctrl_of_match[] > > Looks good to me but I would like Bjorns ACK on this patch before I merge it > if possible.
Ah wait I see that bjorn already merged the DTS file so I guess he's fine with the set. Patch applied!
Yours, Linus Walleij
| |