Messages in this thread | | | Date | Sun, 19 Mar 2023 15:34:07 +0200 | From | Vladimir Oltean <> | Subject | Re: [PATCH net-next v4 4/4] net: dsa: mv88e6xxx: mask apparently non-existing phys during probing |
| |
On Sun, Mar 19, 2023 at 11:06:06AM +0100, Marek Behún wrote: > > + bus->phy_mask = GENMASK(31, mv88e6xxx_num_ports(chip)); > > shouldnt this be > GENMASK(31, mv88e6xxx_num_ports(chip) + chip->info->phy_base_addr) | > GENMASK(chip->info->phy_base_addr, 0) > ? > Or alternatively > ~GENMASK(chip->info->phy_base_addr + mv88e6xxx_num_ports(chip), > chip->info->phy_base_addr)
Good point. Would you mind sending a patch? I prefer the second variant BTW.
| |