Messages in this thread | | | Date | Fri, 17 Mar 2023 08:03:21 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v18 2/3] leds: flash: mt6370: Add MediaTek MT6370 flashlight support |
| |
On Fri, 17 Mar 2023, Lee Jones wrote:
> On Fri, 10 Mar 2023, ChiaEn Wu wrote: > > > From: ChiYuan Huang <cy_huang@richtek.com> > > > > The MediaTek MT6370 is a highly-integrated smart power management IC, > > which includes a single cell Li-Ion/Li-Polymer switching battery > > charger, a USB Type-C & Power Delivery (PD) controller, dual Flash > > LED current sources, a RGB LED driver, a backlight WLED driver, > > a display bias driver and a general LDO for portable devices. > > > > Add support for the MT6370 Flash LED driver. Flash LED in MT6370 > > has 2 channels and support torch/strobe mode. > > > > Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > > Co-developed-by: Alice Chen <alice_chen@richtek.com> > > Signed-off-by: Alice Chen <alice_chen@richtek.com> > > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com> > > Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com> > > --- > > v18: > > - Unwrap each line by 100 chars limit. > > - For joint flash, add more comments above the source code. > > - Remove 'sentinel' comment in of_device_id table declaration. > > --- > > drivers/leds/flash/Kconfig | 13 + > > drivers/leds/flash/Makefile | 1 + > > drivers/leds/flash/leds-mt6370-flash.c | 573 +++++++++++++++++++++++++++++++++ > > 3 files changed, 587 insertions(+) > > create mode 100644 drivers/leds/flash/leds-mt6370-flash.c > > Applied, thanks
Next time, please make checkpatch.pl happy before submitting.
-- Lee Jones [李琼斯]
| |