Messages in this thread | | | From | Linus Walleij <> | Date | Fri, 17 Mar 2023 21:53:40 +0100 | Subject | Re: [PATCH v1 1/1] backlight: hx8357: Convert to agnostic GPIO API |
| |
On Fri, Mar 17, 2023 at 7:51 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> The of_gpio.h is going to be removed. In preparation of that convert > the driver to the agnostic API. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks for fixing this Andy!
> -#if !IS_ENABLED(CONFIG_LCD_HX8357) > +#if IS_ENABLED(CONFIG_LCD_HX8357) > /* > * Himax LCD controllers used incorrectly named > * "gpios-reset" property and also specified wrong > @@ -452,7 +452,7 @@ static struct gpio_desc *of_find_gpio_rename(struct device_node *np, > */ > const char *compatible; > } gpios[] = { > -#if !IS_ENABLED(CONFIG_LCD_HX8357) > +#if IS_ENABLED(CONFIG_LCD_HX8357) > /* Himax LCD controllers used "gpios-reset" */ > { "reset", "gpios-reset", "himax,hx8357" }, > { "reset", "gpios-reset", "himax,hx8369" },
Eh what happened here .. it's even intuitively wrong. I would add Fixes: fbbbcd177a27 ("gpiolib: of: add quirk for locating reset lines with legacy bindings")
It wasn't used until now it seems so not a regression and no need for a separate patch.
Other than that it looks correct. Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |