lkml.org 
[lkml]   [2023]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH RESEND v2 07/11] scsi: scsi_debug: Drop scsi_debug_host_reset() device NULL pointer check
    Date
    The check for device pointer for the SCSI command is unnecessary, so drop
    it.

    The only caller is scsi_try_host_reset() -> eh_host_reset_handler(),
    and there that pointer cannot be NULL.

    Indeed, there is already code later in the same function which does not
    check the device pointer for the SCSI command.

    Signed-off-by: John Garry <john.g.garry@oracle.com>
    ---
    drivers/scsi/scsi_debug.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
    index 749358b48335..47820b9f6326 100644
    --- a/drivers/scsi/scsi_debug.c
    +++ b/drivers/scsi/scsi_debug.c
    @@ -5440,7 +5440,7 @@ static int scsi_debug_host_reset(struct scsi_cmnd *SCpnt)
    int k = 0;

    ++num_host_resets;
    - if ((SCpnt->device) && (SDEBUG_OPT_ALL_NOISE & sdebug_opts))
    + if (SDEBUG_OPT_ALL_NOISE & sdebug_opts)
    sdev_printk(KERN_INFO, SCpnt->device, "%s\n", __func__);
    spin_lock(&sdebug_host_list_lock);
    list_for_each_entry(sdbg_host, &sdebug_host_list, host_list) {
    --
    2.35.3
    \
     
     \ /
      Last update: 2023-03-27 00:56    [W:4.722 / U:0.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site