lkml.org 
[lkml]   [2023]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 5/5] iommu/vt-d: Add nested domain support
From
On 3/13/23 5:11 PM, Liu, Jingqi wrote:
>> +struct iommu_domain *intel_nested_domain_alloc(struct iommu_domain *s2_domain,
>> + const void *user_data)
>> +{
>> + const struct iommu_hwpt_intel_vtd *vtd = user_data;
>> + struct dmar_domain *domain;
>> +
>
> Would it be better to add the following check ?
>
> if (WARN_ON(!user_data))
> return NULL;

The iommufd has already done the sanity check. Considering that this
callback is only for iommufd purpose, the individual driver has no need
to check it.

Best regards,
baolu

\
 
 \ /
  Last update: 2023-03-27 00:57    [W:0.726 / U:0.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site