Messages in this thread Patch in this message | | | From | Luis Chamberlain <> | Subject | [RFC 07/12] module: move check_modinfo() early to early_mod_check() | Date | Fri, 10 Mar 2023 21:17:07 -0800 |
| |
This moves check_modinfo() to early_mod_check(). This doesn't make any functional changes either, as check_modinfo() was the first call on layout_and_allocate(), so we're just moving it back one routine and at the end.
This let's us keep separate the checkers from the allocater.
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> --- kernel/module/main.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/kernel/module/main.c b/kernel/module/main.c index 32c92fb69c05..e9c7eb827f0d 100644 --- a/kernel/module/main.c +++ b/kernel/module/main.c @@ -2284,10 +2284,6 @@ static struct module *layout_and_allocate(struct load_info *info, int flags) unsigned int ndx; int err; - err = check_modinfo(info->mod, info, flags); - if (err) - return ERR_PTR(err); - /* Allow arches to frob section contents and sizes. */ err = module_frob_arch_sections(info->hdr, info->sechdrs, info->secstrings, info->mod); @@ -2702,7 +2698,11 @@ static int early_mod_check(struct load_info *info, int flags) /* Check module struct version now, before we try to use module. */ if (!check_modstruct_version(info, info->mod)) - return ENOEXEC; + return -ENOEXEC; + + err = check_modinfo(info->mod, info, flags); + if (err) + return err; return 0; } -- 2.39.1
| |