Messages in this thread Patch in this message | | | From | Linus Walleij <> | Date | Fri, 10 Mar 2023 23:38:04 +0100 | Subject | Re: [PATCH] PCI: ixp4xx: Use PCI_CONF1_ADDRESS() macro |
| |
On Wed, Sep 28, 2022 at 2:25 PM Pali Rohár <pali@kernel.org> wrote:
> Simplify pci-ixp4xx.c driver code and use new PCI_CONF1_ADDRESS() macro for > accessing PCI config space. > > Signed-off-by: Pali Rohár <pali@kernel.org>
This does not compile right off (on kernel v6.3-rc1), I had to add this:
diff --git a/drivers/pci/controller/pci-ixp4xx.c b/drivers/pci/controller/pci-ixp4xx.c index c83b5ae0b017..e44252db6085 100644 --- a/drivers/pci/controller/pci-ixp4xx.c +++ b/drivers/pci/controller/pci-ixp4xx.c @@ -26,6 +26,7 @@ #include <linux/platform_device.h> #include <linux/slab.h> #include <linux/bits.h> +#include "../pci.h"
/* Register offsets */ #define IXP4XX_PCI_NP_AD 0x00 After this it compiles, boots and mounts root on a PCI-USB-connected rootfs, so it seems to work fine! Tested-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |