lkml.org 
[lkml]   [2023]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] lib/test_bitmap: increment failure counter properly
On Mon, Feb 27, 2023 at 06:49:29PM -0800, Yury Norov wrote:
> On Tue, Feb 28, 2023 at 12:55:05AM +0200, Andy Shevchenko wrote:
> > On Mon, Feb 27, 2023 at 01:45:23PM -0800, Yury Norov wrote:
> > > The tests that don't use expect_eq() macro to determine that a test is
> > > failured must increment failed_tests explicitly.
> >
> > ...
> >
> > > pr_err("bitmap_copy_arr32(nbits == %d:"
> > > " tail is not safely cleared: %d\n",
> >
> > Usually we don't split string literals (since checkpatch doesn't complain on a
> > looong lines with them at the end of the line),
> >
> > ...
> >
> > > pr_err("bitmap_copy_arr64(nbits == %d:"
> > > " tail is not safely cleared: %d\n", nbits, next_bit);
> >
> > Ditto.
> >
> > P.S. Seems a material for another patch.
>
> If you're OK with this patch, can you give your review tag please?

I'm fine with the series,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2023-03-27 00:40    [W:0.041 / U:0.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site