Messages in this thread | | | From | "J.D. Yue" <> | Subject | RE: Re: [PATCH v2 1/7] soc: imx: imx8mp-blk-ctrl: Use dev_pm_domain_attach_by_name | Date | Wed, 1 Mar 2023 12:31:42 +0000 |
| |
> -----Original Message----- > From: Marco Felsch <m.felsch@pengutronix.de> > Sent: Wednesday, March 1, 2023 5:31 PM > To: J.D. Yue <jindong.yue@nxp.com> > Cc: shawnguo@kernel.org; s.hauer@pengutronix.de; Peng Fan > <peng.fan@nxp.com>; gregkh@linuxfoundation.org; > linux-kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>; > kernel@pengutronix.de; festevam@gmail.com; l.stach@pengutronix.de > Subject: [EXT] Re: [PATCH v2 1/7] soc: imx: imx8mp-blk-ctrl: Use > dev_pm_domain_attach_by_name > > > Hi, > > thanks for the patch. > > On 23-03-01, Jindong Yue wrote: > > The genpd_dev_pm_attach_by_name() is not exported, it should not be > > used by consumer driver. > > Use dev_pm_domain_attach_by_name() instead. > > I'm not sure if this is the correct reason. If it wouldn't be allowed to be used by > consumers it would/should be private. Instead you should mention here that > you need the symbol for possible module builds. Same applies to the other > patches. >
You are correct, I ran into symbol undefined errors when building this driver as a module. I will update the commit message in v3 as you suggested. Thank you very much.
> Regards, > Marco > > > > > Signed-off-by: Jindong Yue <jindong.yue@nxp.com> > > --- > > drivers/soc/imx/imx8mp-blk-ctrl.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c > > b/drivers/soc/imx/imx8mp-blk-ctrl.c > > index a0592db8fa86..1892c2c78831 100644 > > --- a/drivers/soc/imx/imx8mp-blk-ctrl.c > > +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c > > @@ -642,7 +642,7 @@ static int imx8mp_blk_ctrl_probe(struct > platform_device *pdev) > > if (!bc->onecell_data.domains) > > return -ENOMEM; > > > > - bc->bus_power_dev = genpd_dev_pm_attach_by_name(dev, "bus"); > > + bc->bus_power_dev = dev_pm_domain_attach_by_name(dev, "bus"); > > if (IS_ERR(bc->bus_power_dev)) > > return dev_err_probe(dev, PTR_ERR(bc->bus_power_dev), > > "failed to attach bus power > > domain\n"); > > -- > > 2.36.0 > > > > > >
| |