lkml.org 
[lkml]   [2023]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] ASoC: cs35l41: Steam Deck Shared boost properties quirk
On Wed, Mar 01, 2023 at 10:31:13AM +0000, Lucas Tanure wrote:
> Add support for Steam Deck bios old properties. If a Steam deck didn't
> upgrade the BIOS, the driver should be able to handle the previous
> properties for shared boost types.
>
> Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>
> ---
> sound/soc/codecs/cs35l41.c | 14 +++++++++++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/cs35l41.c b/sound/soc/codecs/cs35l41.c
> index c223d83e02cf..d5f9eee88cba 100644
> --- a/sound/soc/codecs/cs35l41.c
> +++ b/sound/soc/codecs/cs35l41.c
> @@ -1037,9 +1037,17 @@ static int cs35l41_handle_pdata(struct device *dev, struct cs35l41_hw_cfg *hw_cf
> unsigned int val;
> int ret;
>
> - ret = device_property_read_u32(dev, "cirrus,boost-type", &val);
> - if (ret >= 0)
> - hw_cfg->bst_type = val;
> + if (device_property_read_bool(dev, "cirrus,shared-boost-active")){
> + hw_cfg->bst_type = CS35L41_SHD_BOOST_ACTV;
> + }
> + else if (device_property_read_bool(dev, "cirrus,shared-boost-passive")) {

else should really be on the same line as the closing bracket.
But apart from that minor nit, looks good to me:

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

\
 
 \ /
  Last update: 2023-03-27 00:39    [W:1.034 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site