Messages in this thread | | | Date | Wed, 1 Mar 2023 11:00:52 +0100 | Subject | Re: [PATCH] ASoC: mediatek: add missing initialization | From | AngeloGioacchino Del Regno <> |
| |
Il 01/03/23 05:08, Trevor Wu ha scritto: > In etdm dai driver, dai_etdm_parse_of() function is used to parse dts > properties to get parameters. There are two for-loops which are > sepearately for all etdm and etdm input only cases. In etdm in only > loop, dai_id is not initialized, so it keeps the value intiliazed in > another loop. > > In the patch, add the missing initialization to fix the unexpected > parsing problem. > > Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
I agree about this fix, but this commit is not fine as it is: Please split it in two commits and add the appropriate Fixes tag to each for backports.
Regards, Angelo
| |