Messages in this thread | | | Date | Wed, 1 Mar 2023 20:21:09 -0600 | From | Bjorn Andersson <> | Subject | Re: [PATCH v2 1/1] ufs: mcq: qcom: Fix passing zero to PTR_ERR |
| |
On Wed, Mar 01, 2023 at 05:41:06PM -0800, Asutosh Das wrote: > Fix an error case in ufs_qcom_mcq_config_resource(), where the > return value is set to 0 before passing it to PTR_ERR. > > This led to Smatch warning: > drivers/ufs/host/ufs-qcom.c:1455 ufs_qcom_mcq_config_resource() warn: > passing zero to 'PTR_ERR' > > Fixes: c263b4ef737e ("scsi: ufs: core: mcq: Configure resource regions") > Reported-by: Dan Carpenter <error27@gmail.com> > Signed-off-by: Asutosh Das <quic_asutoshd@quicinc.com>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
> > -- > v1 -> v2 > - Split to 2 patches > - Addressed Mani's comments > -- > --- > drivers/ufs/host/ufs-qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > index 34fc453f3eb1..43b1fc1ad33e 100644 > --- a/drivers/ufs/host/ufs-qcom.c > +++ b/drivers/ufs/host/ufs-qcom.c > @@ -1451,8 +1451,8 @@ static int ufs_qcom_mcq_config_resource(struct ufs_hba *hba) > if (IS_ERR(res->base)) { > dev_err(hba->dev, "Failed to map res %s, err=%d\n", > res->name, (int)PTR_ERR(res->base)); > - res->base = NULL; > ret = PTR_ERR(res->base); > + res->base = NULL; > return ret; > } > } > -- > 2.7.4 >
| |