lkml.org 
[lkml]   [2023]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] m68k: /proc/hardware depends on PROC_FS
From


On 2/9/23 05:54, Geert Uytterhoeven wrote:
> Hi Randy,
>
> On Thu, Feb 9, 2023 at 2:08 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>> When CONFIG_PROC_FS is not set, there is a build error for an unused
>> function. Make PROC_HARDWARE depend on PROC_FS to prevent this error.
>>
>> In file included from ../arch/m68k/kernel/setup.c:3:
>> ../arch/m68k/kernel/setup_mm.c:477:12: error: 'hardware_proc_show' defined but not used [-Werror=unused-function]
>> 477 | static int hardware_proc_show(struct seq_file *m, void *v)
>> | ^~~~~~~~~~~~~~~~~~
>>
>> Fixes: 66d857b08b8c ("m68k: merge m68k and m68knommu arch directories") # v3.0
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>
> Thanks for your patch!
>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> i.e. will queue in the m68k for-v6.3 branch.
>
>> --- a/arch/m68k/Kconfig.devices
>> +++ b/arch/m68k/Kconfig.devices
>> @@ -18,6 +18,7 @@ config HEARTBEAT
>>
>> # We have a dedicated heartbeat LED. :-)
>> config PROC_HARDWARE
>> + depends on PROC_FS
>
> I'll move the "depends ..." line below the "bool ..." line while applying,
> as that's where the dependencies are usually listed.

Agreed. I don't know how I did it like that.

>> bool "/proc/hardware support"
>> help
>> Say Y here to support the /proc/hardware file, which gives you


--
~Randy

\
 
 \ /
  Last update: 2023-03-27 00:16    [W:0.051 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site