Messages in this thread | | | Date | Thu, 9 Feb 2023 16:41:02 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH -tip] kprobes/x86: Remove unneeded casting from immediate value |
| |
On Fri, Feb 10, 2023 at 12:36:36AM +0900, Masami Hiramatsu (Google) wrote: > From: Masami Hiramatsu (Google) <mhiramat@kernel.org> > > Remove unneeded casting from immediate value assignments for relative > jump offset. Since the immediate values in the 'insn' data structure are > assigned from immediate bytes as a signed value to insn.immediate.value > by insn_field_set(). Thus, if we need to access that value as a signed > value (in this kprobe's case), we don't need to cast it. > This is a kind of clean up (should not change behavior) follows Nadav's > bugfix. > > Link: https://lore.kernel.org/all/20230208071708.4048-1-namit@vmware.com/ > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
| |