Messages in this thread | | | Date | Thu, 9 Feb 2023 10:28:59 +0100 | From | Andrew Jones <> | Subject | Re: [PATCH 1/2] RISC-V: fix ordering of Zbb extension |
| |
On Thu, Feb 09, 2023 at 09:03:50AM +0000, Conor Dooley wrote: > On Thu, Feb 09, 2023 at 09:25:20AM +0100, Andrew Jones wrote: > > On Wed, Feb 08, 2023 at 11:20:10PM +0000, Conor Dooley wrote: > > > Hey Heiko, > > > > > > On 8 February 2023 22:53:27 GMT, Heiko Stuebner <heiko@sntech.de> wrote: > > > >From: Heiko Stuebner <heiko.stuebner@vrull.eu> > > > > > > > >As Andrew reported, > > > > Zb* comes after Zi* according 27.11 "Subset Naming Convention" > > > >so fix the ordering accordingly. > > > > > > > >Reported-by: Andrew Jones <ajones@ventanamicro.com> > > > >Signed-off-by: Heiko Stuebner <heiko.stuebner@vrull.eu> > > > > > > The whole "getting it wrong immediately after fixing it up" ;) > > > > Hi Conor, > > > > Do you know any patchwork savvy people that could whip up a check > > for this array? :-) > > Maybe that is more of a checkpatch type thing?
I think this is too specific for general checkpatch. I once proposed on the KVM mailing list that checkpatch should gain support for plugins, allowing specific directories to provide a .checkpatch script, or whatever, where it puts its own checks. I never followed-up by actually proposing that to checkpatch maintainers though.
> > Either way, I'll put it on the todo list I suppose!
In the absence of checkpatch plugins, I think subsystem-specific patch management tools, like patchwork, are the next best place to put specific checks. But, I agree it's a bit late. It'd be better if the developers could run the checks themselves before posting.
Thanks, drew
| |