lkml.org 
[lkml]   [2023]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] media: cec: i2c: ch7322: Drop of_match_ptr
Hi Joshua,

On Wed, Feb 08, 2023 at 01:54:04PM -0500, Joshua Pius wrote:
> Tested-by: stop cecservice, cec-ctl on endeavour
>
>

Ah, no, that should have been

Tested-by: Joshua Pius <joshuapius@google.com>

and please do it inline (after Signed-off-by: or Cc:).
Top-posting is discouraged on kernel mailing lists.

Thanks,
Guenter

>
>
> Joshua Pius
>
> Software Developer
>
>
> careers.google.com
>
> <https://ca.linkedin.com/in/joshua-pius>
> <https://www.youtube.com/user/lifeatgoogle>
> <https://www.facebook.com/lifeatgoogle/> <https://twitter.com/lifeatgoogle>
> <https://www.instagram.com/lifeatgoogle>
>
> <https://news.engineering.utoronto.ca/grads-to-watch-2022/#row14>
>
> |Learn more about our candidate privacy policy.|
> <https://careers.google.com/privacy-policy/>
>
>
>
>
> On Wed, Feb 8, 2023 at 1:45 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> > The driver does not instantiate on ACPI based systems if OF is disabled.
> > Fix the problem by dropping of_match_ptr.
> >
> > Cc: Joshua Pius <joshuapius@google.com>
> > Fixes: 21b9a47e0ec7 ("media: cec: i2c: ch7322: Add ch7322 CEC controller
> > driver")
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> > drivers/media/cec/i2c/ch7322.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/cec/i2c/ch7322.c
> > b/drivers/media/cec/i2c/ch7322.c
> > index 34fad7123704..3c6e6496a001 100644
> > --- a/drivers/media/cec/i2c/ch7322.c
> > +++ b/drivers/media/cec/i2c/ch7322.c
> > @@ -589,7 +589,7 @@ MODULE_DEVICE_TABLE(of, ch7322_of_match);
> > static struct i2c_driver ch7322_i2c_driver = {
> > .driver = {
> > .name = "ch7322",
> > - .of_match_table = of_match_ptr(ch7322_of_match),
> > + .of_match_table = ch7322_of_match,
> > },
> > .probe_new = ch7322_probe,
> > .remove = ch7322_remove,
> > --
> > 2.39.1
> >
> >

\
 
 \ /
  Last update: 2023-03-27 00:15    [W:1.262 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site